Compare mtime with Equal() rather than == - #381
Merged
Conversation
The "leave the timestamps alone if the mtime is the epoch" shortcut in the LocalFS writers compared with ==, which on time.Time also compares the monotonic reading and the location. An epoch mtime carrying a location other than time.Local therefore didn't match, and the file or directory had its timestamps set to 1970 instead of being left as written. Use Equal(), which compares the instant only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LocalFS writers skip setting timestamps when the node's mtime is the epoch, treating that as "unset". The check used
n.MTime == time.Unix(0, 0).==ontime.Timecompares the wall clock, the monotonic reading and the location pointer, so it only matches an epoch mtime that happens to carrytime.Local. The same instant in UTC or any other location falls through toChtimes()and the entry gets its timestamps set to 1970 rather than being left alone.Switched the three sites to
Equal(), which compares the instant only:localfs.go—applyDirMetadata()andCreateFile()localfs_other.go—CreateDevice()Found by
staticcheck's QF1009 (enabled by default in golangci-lint, but not in thestaticcheckrun in CI).